Conversation
|
Thanks @rajkundu, this looks a useful addition in principle. Ideally I'd like to see the change accompanied with a unit test so we don't drop code coverage. That should also help us no if it runs OK on Linux and Windows when it goes trough github actions. Do you think you can have a go at implementing that? |
|
I haven't written any before, but I have always wanted to learn, so sure - I'll try my best! |
|
OK, thanks. Please have a try and I'll be happy to help. You should be able to turn on github actions on your fork so you can see the test results each time you push. |
This PR fixes #62 by adding the
parallel probeconfiguration option. Whenconfiguration['parallel probe'] = True,concurrent.futuresis imported, andconcurrent.futures.ProcessPoolExecutoris used to simultaneously probe serial ports. Rather than check ports sequentially, this option allows_get_serial_port_nameto return as soon as an NDI device is found on any serial port.So far, this change has only been tested on an Intel MacBook Pro running macOS 12.5.