Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
- "27017:27017"

scicat:
image: ghcr.io/scicatproject/backend-next:v4.8.0
image: ghcr.io/scicatproject/backend-next:v4.20.2
container_name: scitacean-test-scicat
depends_on:
- mongodb
Expand Down
17 changes: 14 additions & 3 deletions tests/client/attachment_client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ def compare_attachment_after_upload(
assert expected == dict(downloaded)[key], f"key = {key}"


def sorted_attachments(
attachments: list[DownloadAttachment],
) -> list[DownloadAttachment]:
return sorted(attachments, key=lambda a: str(a.id))


def test_create_attachment_for_dataset(
scicat_client: ScicatClient,
attachment: UploadAttachment,
Expand All @@ -90,6 +96,7 @@ def test_create_attachment_for_dataset(
compare_attachment_after_upload(attachment2, finalized2)


@pytest.mark.skip("https://github.com/SciCatProject/scicat-backend-next/issues/2254")
def test_create_attachment_for_dataset_with_existing_id(
real_client: Client,
attachment: UploadAttachment,
Expand Down Expand Up @@ -140,7 +147,9 @@ def test_create_attachment_for_dataset_for_dataset_populates_ids(
def test_get_attachments_for_dataset(scicat_client: ScicatClient) -> None:
dset = INITIAL_DATASETS["derived"]
attachments = scicat_client.get_attachments_for_dataset(dset.pid)
assert attachments == INITIAL_ATTACHMENTS["derived"]
assert sorted_attachments(attachments) == sorted_attachments(
INITIAL_ATTACHMENTS["derived"]
)


def test_get_attachments_for_dataset_no_attachments(
Expand Down Expand Up @@ -168,7 +177,9 @@ def test_download_attachments_for_dataset(client: Client, key: str) -> None:
Attachment.from_download_model(attachment)
for attachment in INITIAL_ATTACHMENTS.get(key, ())
]
assert with_attachments.attachments == expected
assert sorted_attachments(with_attachments.attachments) == sorted_attachments(
expected
)


@pytest.mark.parametrize("key", ["raw", "derived"])
Expand All @@ -179,4 +190,4 @@ def test_get_dataset_with_attachments(client: Client, key: str) -> None:
Attachment.from_download_model(attachment)
for attachment in INITIAL_ATTACHMENTS.get(key, ())
]
assert downloaded.attachments == expected
assert sorted_attachments(downloaded.attachments) == sorted_attachments(expected)
4 changes: 2 additions & 2 deletions tests/model_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_derived_dataset_default_values(
assert finalized.size == 0
assert finalized.techniques == []
assert finalized.updatedAt # some non-empty str
assert finalized.version == "v3"
assert finalized.version == "3"

# Left empty
assert finalized.description is None is None
Expand Down Expand Up @@ -222,7 +222,7 @@ def test_raw_dataset_default_values(
assert finalized.size == 0
assert finalized.techniques == []
assert finalized.updatedAt # some non-empty str
assert finalized.version == "v3"
assert finalized.version == "3"

# Left empty
assert finalized.dataFormat is None
Expand Down
Loading