Skip to content

feat: update images in template Dockerfile - #411

Open
philiplb wants to merge 1 commit into
SchwarzIT:mainfrom
philiplb:feature/update-docker-images
Open

philiplb wants to merge 1 commit into
SchwarzIT:mainfrom
philiplb:feature/update-docker-images

Conversation

@philiplb

@philiplb philiplb commented May 8, 2026

Copy link
Copy Markdown

This commit updates the images used in the template Dockerfile to the latest versions as of writing:

  • golang:1.25.10: the latest 1.25 version which is used in the initial go.mod file generated by Go 1.26

  • gcr.io/distroless/static:nonroot

@philiplb
philiplb requested a review from a team as a code owner May 8, 2026 14:31
@philiplb philiplb changed the title Update images in template Dockerfile feat: update images in template Dockerfile May 8, 2026
@philiplb
philiplb force-pushed the feature/update-docker-images branch from 6a170b6 to 0e0f627 Compare May 8, 2026 14:32
This commit updates the images used in the template Dockerfile to the
latest versions as of writing:

- golang:1.25.10: the latest 1.25 version which is used in the initial
  go.mod file generated by Go 1.26

- gcr.io/distroless/static:nonroot
@philiplb
philiplb force-pushed the feature/update-docker-images branch from 0e0f627 to c0d83b8 Compare May 8, 2026 14:42
@philiplb

philiplb commented May 8, 2026

Copy link
Copy Markdown
Author

Re-requesting the review as the first time the check "test (ubuntu-latest)" failed with a

Error: A branch or tag with the name 'feature/update-docker-images' could not be found

So to retrigger the check, I edited the commit message and force pushed.

@philiplb
philiplb requested a review from zalgonoise May 8, 2026 14:45
@philiplb

philiplb commented May 8, 2026

Copy link
Copy Markdown
Author

Welp, it failed again with the same error. Maybe the pipeline can't handle PRs from forked repos yet? I will investigate.

@zalgonoise

Copy link
Copy Markdown
Contributor

Welp, it failed again with the same error. Maybe the pipeline can't handle PRs from forked repos yet? I will investigate.

Yes, it looks like the pipeline only fetches the branches in the repo, I will take a look later if Marvin doesn't get to it first :) thanks for contributing

@philiplb

philiplb commented May 8, 2026

Copy link
Copy Markdown
Author

Welp, it failed again with the same error. Maybe the pipeline can't handle PRs from forked repos yet? I will investigate.

Yes, it looks like the pipeline only fetches the branches in the repo, I will take a look later if Marvin doesn't get to it first :) thanks for contributing

Awesome, thank you :)

@MarvinJWendt

Copy link
Copy Markdown
Member

Hey, thanks for contributing! Maybe we could already upgrade to go 1.26 :)
I'll be on vacation soon, we can ignore the pipeline errors for now.

@philiplb

Copy link
Copy Markdown
Author

I've set it to the latest version of Go 1.25 because that's what you get in your go.mod file after running go mod init with an installed Go 1.26. So in order to make the go.mod match with the Dockerfile, I went with 1.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants