fix + test#40
Merged
Merged
Conversation
tislam2-hue
commented
Jun 29, 2026
T-Burton-ND
requested changes
Jul 6, 2026
T-Burton-ND
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKIT fallback for aromatic molecules no longer throw away hydrogen maps. Also
xyz_from_smilesandgeo_via_rdkitare updated to use functions fromutil/rdkit.pyin stead of writing them every time. One test added to verify helpers work as expected by seeing if the adjacency generated from a smiles string with mapped hydrogens is the same as that with unmapped hydrogens.