fix: governance delegation, receipt title, embed resize, recurring billing - #746
Merged
dotunv merged 1 commit intoAug 31, 2026
Merged
Conversation
…lling Resolves Savitura#735, Savitura#733, Savitura#734, Savitura#738. - governance (Savitura#735): add off-chain vote delegation chain. New governance_delegations table plus set/revoke routes; effective vote weight now aggregates delegator token balances recursively with circular/self-delegation prevention; vote weight stored per proposal. - receipt title (Savitura#733): contribution receipts already read the title live; lock it in with a regression test and invalidate the campaign cache on rename so no downstream consumer serves a stale title. - embed resize (Savitura#734): harden iframe height reporting for iOS Safari by measuring both documentElement and body, observing both with ResizeObserver, and re-measuring on window resize, font, and image loads. - recurring billing (Savitura#738): automate monthly charges by running each due schedule through the custodial Stellar payment flow; send upcoming/charged/ failed email notices; apply exponential backoff on failed charges via new failure_count/last_error columns; surface recurring contributions in creator analytics. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@p4uld4vid016-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #735, #733, #734, and #738.
governance_delegationstable +set/revoke/vote-weightroutes. Effective vote weight now aggregates delegator token balances recursively through the chain, with circular-delegation and self-delegation prevention.token_balance_at_votereflects the aggregated power.campaignsat send time; added a regression test to lock that in, and invalidated thecampaigns:idcache on rename so no downstream consumer (receipts, embeds) ever serves a stale title.documentElementandbody, observe both withResizeObserver, and re-measure onwindow.resize, font-load, and image-load.upcoming/charged/failedemail notices; failed charges retry with exponential backoff (newfailure_count/last_errorcolumns); recurring contributions are surfaced in creator analytics.Notes
#733's main code path was already reading the title fresh; the fix hardens cache invalidation and adds coverage.Testing
node --test).CampaignEmbedresize tests updated and passing (vitest).eslintclean on all changed files.Closes #735
Closes #733
Closes #734
Closes #738