-
Notifications
You must be signed in to change notification settings - Fork 68
Deduplicate wallet and sandbox modules #57
Copy link
Copy link
Closed
Labels
GrantFox OSSIssue tracked in GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Campaign: Official Campaign | FWC26backendBackend / API workBackend / API workenhancementNew feature or requestNew feature or request
Description
Activity
Metadata
Metadata
Assignees
Labels
GrantFox OSSIssue tracked in GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Campaign: Official Campaign | FWC26backendBackend / API workBackend / API workenhancementNew feature or requestNew feature or request
Description
The
wallet/andsandbox/modules share nearly identical logic:generateKeypairfundFromFriendbotBoth are used by different frontend pages but implement the same core operations.
Directories:
apps/api/src/modules/wallet/apps/api/src/modules/sandbox/Proposed Approach
Option A: Merge into a single
walletmodule and have the Sandbox page call wallet endpoints.Option B: Keep separate modules but extract shared logic into a common service.
Benefits
Acceptance Criteria