Return future-dated subscription pools from stage #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the API requests that fetch the list of subscription pools to include future-dated subscriptions when using a stage RHSM account while leaving requests to prod RHSM unchanged.
JacobCallahan
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
PR Overview
This PR modifies the API calls in the pools endpoint for stage RHSM accounts to include future-dated subscription pools while keeping production behavior unchanged.
- Append query parameter "?future=true" to the pools endpoint URL for stage environments.
- Preserve legacy functionality for production environments.
Reviewed Changes
| File | Description |
|---|---|
| manifester/helpers.py | Append query parameter for stage pools endpoint URL. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
manifester/helpers.py:75
- Appending a query parameter using a fixed '?' may break if the URL already contains existing query parameters. Consider using a URL parsing or manipulation library to robustly append the parameter.
_endpoint_url = _endpoint_url + "?future=true"
|
Copilot's one suppressed suggestion here is not valid in this case as the URL will deterministically not have additional query parameters. Point taken, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the API requests that fetch the list of subscription pools to include future-dated subscriptions when using a stage RHSM account while leaving requests to prod RHSM unchanged.