Closed
Conversation
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new locators rely heavily on specific IDs (e.g.,
webhookCreateModal,typeahead-select-input-event); consider whether there are more stable attributes or patterns (like data-* attributes or form structure) that would be less brittle to UI refactors. - Within
general, the locators mixidandnameattributes (namenow usesid, whiletarget_urlstill usesname); consider standardizing on one approach for similar fields to keep the view definition consistent and easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new locators rely heavily on specific IDs (e.g., `webhookCreateModal`, `typeahead-select-input-event`); consider whether there are more stable attributes or patterns (like data-* attributes or form structure) that would be less brittle to UI refactors.
- Within `general`, the locators mix `id` and `name` attributes (`name` now uses `id`, while `target_url` still uses `name`); consider standardizing on one approach for similar fields to keep the view definition consistent and easier to maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
closing in favor of https://github.com/SatelliteQE/airgun/pull/2256/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip, should go hand in hand with theforeman/foreman_webhooks#91