Add MidnightSunException, PolarNightException #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enough for an expection that just contains a message ( https://stackoverflow.com/a/1319675 ). To verify that it works as expected, the TestNoSun tests are expanded to check the exception message.
Instead of just raising SunTimeException, report whether we have midnight sun or polar night. Implemented in a backwards-compatible way by subclassing SunTimeException. That catching SunTimeException still works as before is verified by extending the tests. Fixes SatAgro#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just raising SunTimeException, report
whether we have midnight sun or polar night.
Implemented in a backwards-compatible way by
subclassing SunTimeException.
That catching SunTimeException still works as before
is verified by extending the tests.
Fixes #32