-
-
Notifications
You must be signed in to change notification settings - Fork 185
Feat: Add support for SteelSeries Arctis Nova 3P Wireless #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It seems like most (if not all) of the commands for each capability are the same, except without the |
Yeah, I copied most of the code |
f3a551e
to
16a6fd2
Compare
Support for Linux works fine on my end. Unfortunately inside my Windows VM things don't work (I tried all |
Windows support is a bit tricky, it expects the exact same length. https://github.com/libusb/hidapi/blob/f18d2c0768bed300d13758dd9f52b57163c0498f/windows/hid.c#L1256 I think we can merge anyways, we just need to maybe include some message or at least a comment that windows seems to not quite work yet with that implementation |
Alright, where should I write the message/comment? |
Are all functions erroring out or only specific? |
From what I recall, nothing works on windows and they don't error out but instead just don't have any effects. |
I'll be adding support for SteelSeries Arctis Nova 3P Wireless. Right now I managed to get the sidetone working.
I first tried seeing if the implementation of SteelSeries Arctis Nova 3 works for this model as well, but it doesn't.