Skip to content

first review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrGeli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

first review #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dtoModule/tileDTO.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from src.enums.tileStatus import TileStatus

# what is DTO? Please do not use abbreviations that are not clear
class TileDTO():

def __init__(self, tileStatus: TileStatus, pedastrianValue: float) -> None:
Expand Down
1 change: 1 addition & 0 deletions src/enums/tileStatus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from enum import Enum

# since it is a *cell*ular automaton, there might be a more appropriate name than tile;-)?
def TileStatus(Enum):
FREE = 1
BLOCKED = 2
Expand Down
1 change: 1 addition & 0 deletions src/simulation/tile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from random import uniform

# sure it's a tile?
class Tile():

def __init__(self, tileDTO: TileDTO) -> None:
Expand Down