This repository was archived by the owner on Jun 16, 2026. It is now read-only.
fix(useFilterSuggestions): resolve SSR crash by deferring localStorage access#9212
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix(useFilterSuggestions): resolve SSR crash by deferring localStorage access#9212tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
…e access Replace globalThis.localStorage default parameter with undefined and access window.localStorage inside the function body after an SSR guard. Closes SandeepVashishtha#9206.
Contributor
|
@tmdeveloper007 is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc:approved
Contributor
Author
|
@SandeepVashishtha Ready for review — PR #9212: Fix SSR crash in useFilterSuggestions localStorage default |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the globalThis.localStorage default parameter in src/hooks/useFilterSuggestions.js with undefined and access window.localStorage via a conditional expression inside the function body.
Changes
Impact
Fixes server-side rendering crashes. Filter suggestions feature fails during SSR without this fix.
Closes #9206.