feat: add achievement showcase to player profile - #1222
Merged
Samuel1-ona merged 2 commits intoAug 27, 2026
Conversation
- Add AchievementShowcase component with pin/unpin via server-backed showcase (apps/web/app/api/v1/achievements/showcase) - Add ownerSecret-authenticated PUT + public GET route, backed by showcaseStore.ts (app_settings table) - Add progress tracking (getAchievementProgress) against PROGRESS_THRESHOLDS in config.ts - Remove dead localStorage-based pin/unpin functions from service.ts (superseded by server-backed showcase) - Wire AchievementShowcase into PlayerProfileView Note: pnpm tsc --noEmit -p apps/web reports 2 pre-existing syntax errors in apps/web/app/api/push-tokens/route.ts and apps/web/hooks/useHuntDraftAutoSave.ts. These are unrelated to this change, present in HEAD prior to this branch, and intentionally left untouched per scope discipline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1203
Summary
Adds an achievement showcase to player profiles, allowing players to pin up to three achievements and view their artwork, criteria, and progress.
What changed
AchievementShowcaseto player profiles.GETand authenticatedPUTshowcase API endpoints.Acceptance criteria
Verification
ESLint passed across all changed and new files.
git diff --checkpassed.pnpm tsc --noEmit -p apps/webwas run.TypeScript reports two pre-existing, unrelated syntax errors in:
apps/web/app/api/push-tokens/route.tsapps/web/hooks/useHuntDraftAutoSave.tsWorking tree is clean after commit.
Scope
This PR keeps the existing achievement earning system unchanged. It does not introduce a server-side source of truth for earned achievements or migrate the existing localStorage-backed achievement system.
Server-side persistence is limited to the profile showcase data. Server-authoritative achievement ownership/validation can be addressed separately if needed.