FEAT Push notification preferences per category #1200 FIXED - #1221
Open
madisonsc52-del wants to merge 1 commit into
Open
Conversation
Author
|
@Samuel1-ona |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
The repository already contained notification infrastructure, but it lacked complete user-facing and cross-device preference control:
Mobile preferences were local-only
AsyncStorage.Web preferences were browser-only
localStorage.No notification preference API existed
/api/v1/routes did not include an endpoint for reading or saving notification preferences.The web settings page was not available in the active web App Router
apps/web/approute structure.apps/web/app/settings/page.tsx.Web push used device-level flags
Some notification channels bypassed the global mute
Push route merge artifacts were present
push-tokens/route.tsandpush/send/route.tscontained duplicate implementations from a merge conflict.Fix Features
The implementation now provides:
Independent notification category toggles:
A global Mute all notifications control.
Wallet-scoped preference synchronization through:
Mobile preference synchronization using the connected wallet address.
Web preference hydration when a wallet connects.
Server-side push filtering using the canonical wallet preference document.
Global/category filtering for:
Push subscription preference synchronization for global and category settings.
New API tests covering:
Repaired duplicate push API route implementations so the notification infrastructure has one valid implementation per route.
CLOSE #1200