Conversation
Contributor
ornwoo96
commented
Aug 22, 2021
ornwoo96
commented
- tabitem 클릭시 해당 viewcontroller 이동작업은 진행중입니다.
jeongjaein
reviewed
Aug 22, 2021
Comment on lines
+18
to
+21
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
필요하지 않은 줄바꿈인 것 같습니다
|
|
||
| protocol CameraViewProtocol: AnyObject { | ||
| var presenter: CameraPresenterProtocol? { get set } | ||
|
|
| } | ||
|
|
||
| func showMemo(for name: String) { | ||
| router?.presentMemoScreen(from: view!, forname: name) |
There was a problem hiding this comment.
view가 무조건 있을 건 알지만
앱 내 전체적으로 강제언래핑 보단 옵셔널 바인딩을 사용했으면 좋겠습니다.
|
|
||
| class HomeViewController: UIViewController { | ||
|
|
||
| let items = ["1월","2월","3월","4월","5월","6월","7월","8월","9월","10월","11월","12월"] |
Comment on lines
+26
to
+48
| // let segmetedControl = UISegmentedControl(items: items) | ||
| // | ||
| // let scrollView = UIScrollView() | ||
| // scrollView.contentSize = CGSize(width: .zero, height: 50) | ||
| // | ||
| // scrollView.addSubview(segmetedControl) | ||
| // view.addSubview(scrollView) | ||
| // | ||
| // scrollView.do { | ||
| // $0.translatesAutoresizingMaskIntoConstraints = false | ||
| // $0.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor).isActive = true | ||
| // $0.leadingAnchor.constraint(equalTo: view.leadingAnchor).isActive = true | ||
| // $0.heightAnchor.constraint(equalToConstant: 50).isActive = true | ||
| // } | ||
| // segmetedControl.do { | ||
| // $0.translatesAutoresizingMaskIntoConstraints = false | ||
| // $0.topAnchor.constraint(equalTo: scrollView.topAnchor).isActive = true | ||
| // $0.leadingAnchor.constraint(equalTo: scrollView.leadingAnchor).isActive = true | ||
| // $0.trailingAnchor.constraint(equalTo: scrollView.trailingAnchor).isActive = true | ||
| // $0.bottomAnchor.constraint(equalTo: scrollView.bottomAnchor).isActive = true | ||
| // $0.heightAnchor.constraint(equalToConstant: 45).isActive = true | ||
| // } | ||
| // |
| class MemoViewController: UIViewController { | ||
| var presenter: MemoViewPresenterProtocol? | ||
| var chuImage = UIImageView() | ||
| let memoNavBar = UINavigationBar() |
| let centerButton = UIButton() | ||
| let cameraButton = UIButton() | ||
| let libraryButton = UIButton() | ||
| var centerButtonExpanded: Bool = true |
There was a problem hiding this comment.
Suggested change
| var centerButtonExpanded: Bool = true | |
| var isCenterButtonExpanded: Bool = true |
요론 물음표 느낌도 괜찮습니다 이해하기가 편해요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.