Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version up to 1.10.0 #636

Merged
merged 12 commits into from
Dec 19, 2024
Merged

Version up to 1.10.0 #636

merged 12 commits into from
Dec 19, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 18, 2024

Description

Please include a summary of the change and which is fixed.

  • version up
  • fix experiment workflow with old action
  • temporally updated ml_config.json. Was trained without last byte = 0A md5sum ec3ac77a923fed769fd95d567ef75137
  • Added dependency check for requirements

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

xDizzix
xDizzix previously approved these changes Dec 18, 2024
@iuriimet iuriimet self-requested a review December 18, 2024 10:14
iuriimet
iuriimet previously approved these changes Dec 18, 2024
@babenek babenek marked this pull request as ready for review December 18, 2024 10:47
@babenek babenek requested a review from a team as a code owner December 18, 2024 10:47
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (8725d64) to head (1b89a49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   92.41%   92.45%   +0.03%     
==========================================
  Files         135      134       -1     
  Lines        4771     4782      +11     
  Branches      751      759       +8     
==========================================
+ Hits         4409     4421      +12     
+ Misses        229      226       -3     
- Partials      133      135       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek dismissed stale reviews from xDizzix and iuriimet via b164a1d December 18, 2024 11:10
@babenek babenek requested review from Yullia, csh519 and kmnls December 18, 2024 11:17
@babenek babenek marked this pull request as draft December 18, 2024 13:09
@babenek babenek requested review from xDizzix and iuriimet December 18, 2024 15:30
@babenek babenek marked this pull request as ready for review December 18, 2024 16:29
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit 5ad122c into main Dec 19, 2024
34 checks passed
@babenek babenek deleted the babenek-patch-1 branch December 19, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants