Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiprocess pool refactored #583

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Multiprocess pool refactored #583

merged 4 commits into from
Jul 16, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 14, 2024

Description

Please include a summary of the change and which is fixed.

  • Used unordered_map to speedup a bit (~10%)
  • Use splitted sequences of providers lists to utilize multiple processes efficency
    BEFORE:
    Screenshot from 2024-07-14 10-03-38
    NOW:
    Screenshot from 2024-07-14 10-05-09

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek changed the title Multiproc Multiprocess pool refactored Jul 14, 2024
@babenek babenek marked this pull request as ready for review July 14, 2024 07:41
@babenek babenek requested a review from a team as a code owner July 14, 2024 07:41
@babenek
Copy link
Contributor Author

babenek commented Jul 15, 2024

@Samsung/credsweeper_maintainers , please review the PR

Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (9acea8b) to head (54591e7).

Files Patch % Lines
credsweeper/app.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   90.23%   90.28%   +0.04%     
==========================================
  Files         131      131              
  Lines        4680     4683       +3     
  Branches      755      756       +1     
==========================================
+ Hits         4223     4228       +5     
+ Misses        304      302       -2     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek merged commit 9800cb6 into Samsung:main Jul 16, 2024
27 checks passed
@babenek babenek deleted the multiproc branch July 16, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants