Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord bot token and Grafana service #574

Merged
merged 29 commits into from
Jul 9, 2024
Merged

Discord bot token and Grafana service #574

merged 29 commits into from
Jul 9, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jun 26, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add Discord bot token pattern and filter (test sample)
  • Add Grafana service token pattern and filter (tested for tokens from opensource repos)
  • skip .map .rc .vdproj .rc2 files from scan
  • actualize Facebook token pattern
  • fix quotation keyword pattern (skip some filters for well quoted values)

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek force-pushed the sanitizer branch 2 times, most recently from 08fdeff to ce67e8b Compare June 28, 2024 08:29
@babenek babenek changed the title Sanitizer Discord bot token and Grafana service Jul 3, 2024
@babenek babenek marked this pull request as ready for review July 3, 2024 08:59
@babenek babenek requested a review from a team as a code owner July 3, 2024 08:59
xDizzix
xDizzix previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek marked this pull request as draft July 8, 2024 13:14
@babenek babenek marked this pull request as ready for review July 9, 2024 07:17
csh519
csh519 reviewed Jul 9, 2024
View reviewed changes
credsweeper/common/constants.py Show resolved Hide resolved
credsweeper/rules/config.yaml Show resolved Hide resolved
.github/workflows/benchmark.yml Show resolved Hide resolved
@babenek babenek requested a review from csh519 July 9, 2024 08:23
kmnls
kmnls approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Yullia
Yullia approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit a936b81 into Samsung:main Jul 9, 2024
27 checks passed
@babenek babenek deleted the sanitizer branch July 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmnls kmnls kmnls approved these changes

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@babenek @xDizzix @Yullia @csh519 @kmnls