Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT detect improvement #454

Closed
wants to merge 1 commit into from
Closed

JWT detect improvement #454

wants to merge 1 commit into from

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 17, 2023

Description

Please include a summary of the change and which is fixed.

based on #468

  • Reviewed rules which may be a JWT - applied url-safe pattern
  • Separated decode_base64 with padding detection and urlsafe

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (75f7803) 90.83% compared to head (03c6b3d) 90.82%.

Files Patch % Lines
credsweeper/utils/util.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   90.83%   90.82%   -0.02%     
==========================================
  Files         123      123              
  Lines        4169     4175       +6     
  Branches      658      660       +2     
==========================================
+ Hits         3787     3792       +5     
  Misses        252      252              
- Partials      130      131       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek force-pushed the jwt branch 2 times, most recently from dcf460b to 5c92723 Compare November 29, 2023 12:26
@babenek babenek marked this pull request as ready for review November 29, 2023 17:25
@babenek babenek requested a review from a team as a code owner November 29, 2023 17:25
@babenek babenek marked this pull request as draft December 1, 2023 13:44
@babenek babenek closed this Dec 8, 2023
@babenek babenek deleted the jwt branch December 8, 2023 05:53
@babenek babenek restored the jwt branch December 8, 2023 05:54
@babenek babenek deleted the jwt branch December 8, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants