Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build.os instead of build.image #445

Merged
merged 15 commits into from
Oct 20, 2023
Merged

Use build.os instead of build.image #445

merged 15 commits into from
Oct 20, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Oct 20, 2023

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f31f2bb) 90.77% compared to head (b0f27fb) 90.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files         125      125              
  Lines        4172     4179       +7     
  Branches      661      662       +1     
==========================================
+ Hits         3787     3794       +7     
  Misses        252      252              
  Partials      133      133              
Files Coverage Δ
credsweeper/rules/rule.py 89.13% <100.00%> (+0.40%) ⬆️
credsweeper/scanner/scanner.py 93.69% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review October 20, 2023 03:04
@babenek babenek requested a review from a team as a code owner October 20, 2023 03:04
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the modification of ReadTheDocs.

LGTM 👍

@babenek babenek merged commit e5b112e into main Oct 20, 2023
29 checks passed
@babenek babenek deleted the readthedocs branch October 20, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants