Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql_password markup #187

Merged
merged 7 commits into from
Jan 23, 2025
Merged

sql_password markup #187

merged 7 commits into from
Jan 23, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 14, 2025 •
edited
Loading

Markup for SQL password pattern Samsung/CredSweeper#653

@babenek babenek marked this pull request as ready for review January 15, 2025 09:06
@babenek babenek requested a review from a team as a code owner January 15, 2025 09:06
babenek
babenek commented Jan 15, 2025
View reviewed changes
Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@babenek babenek requested a review from VladSamsung January 16, 2025 09:02
@babenek babenek requested review from xDizzix, Yullia, iuriimet, daraeahn, csh519, kmnls and VladSamsung and removed request for VladSamsung January 20, 2025 08:42
@babenek babenek mentioned this pull request Jan 21, 2025
Merged
2 tasks
csh519
csh519 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL Password category markups are added with some Password.

LGTM 👍

@babenek babenek requested review from Dmitriy-NK and removed request for VladSamsung January 23, 2025 07:29
Dmitriy-NK
Dmitriy-NK approved these changes Jan 23, 2025
View reviewed changes
Copy link

@Dmitriy-NK Dmitriy-NK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for update markup with SQL passwords

@babenek babenek merged commit 4079250 into Samsung:main Jan 23, 2025
4 checks passed
@babenek babenek deleted the sqlpass branch January 23, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmitriy-NK Dmitriy-NK Dmitriy-NK approved these changes

@csh519 csh519 csh519 approved these changes

@VladSamsung VladSamsung VladSamsung approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@daraeahn daraeahn Awaiting requested review from daraeahn

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babenek @Dmitriy-NK @csh519 @VladSamsung