Improve french translation and R.string usage #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you open a pull request to my fork of the repo with those changes so that I can do the same for the Bulgarian translation? I will translate the french strings. I just don't know how to replace the hard coded strings with ones from the file. |
|
We are managing all French translations internally. Please resubmit w/only the R.string usage changes. Thank you. |
SamouraiDev
force-pushed
the
develop
branch
from
be4aae7 to
c71f21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This patch improve french translation and also replace some strings with more generic R.string.
I have tried to rgrep most of the strings. For example "enable/disable" should be gone.
I have tested it with AVD manager and there is no obvious bug.
However, I added new empty lines in strings.xml.
Sorry for that. If its really important I can clean it.