fix: better stubbing

lib/tcr.rb

@@ -59,13 +59,17 @@ def turned_off(&block)
 # The monkey patch shim
 class TCPSocket
   class << self
-    alias_method :real_open,  :open
+    [:new, :open].each do |m|
+      alias_method "real_#{m}", m
 
-    def open(address, port, *args)
-      if TCR.configuration.hook_tcp_ports.include?(port)
-        TCR::RecordableTCPSocket.new(address, port, TCR.cassette)
-      else
-        real_open(address, port)
+      define_method m do |*args|
+        if TCR.configuration.hook_tcp_ports.include?(args[1])
+          TCR::RecordableTCPSocket.new(TCR.cassette) do
+            send("real_#{m}", *args)
+          end
+        else
+          send("real_#{m}", *args)
+        end
       end
     end
   end

lib/tcr/recordable_tcp_socket.rb

@@ -8,22 +8,22 @@ class RecordableTCPSocket
     attr_reader :live, :socket
     attr_accessor :recording
 
-    def initialize(address, port, cassette)
+    def initialize(cassette)
       raise TCR::NoCassetteError.new unless TCR.cassette
 
       @read_lock = Queue.new
 
       if cassette.recording?
         @live = true
-        @socket = TCPSocket.real_open(address, port)
+        @socket = yield
       else
         @live = false
       end
       @recording = cassette.next_session
     end
 
-    def read(bytes)
-      _read(:read, bytes)
+    def read(*args)
+      _read(:read, *args)
     end
 
     def gets(*args)

spec/tcr_spec.rb

@@ -157,6 +157,14 @@
       }.to change{ File.exists?("./test.json") }.from(false).to(true)
     end
 
+    it "createas a cassette file on use" do
+      expect {
+        TCR.use_cassette("test") do
+          TCPSocket.new("smtp.mandrillapp.com", 2525)
+        end
+      }.to change{ File.exists?("./test.json") }.from(false).to(true)
+    end
+
     it "records the tcp session data into the file" do
       TCR.use_cassette("test") do
         tcp_socket = TCPSocket.open("smtp.mandrillapp.com", 2525)
@@ -214,6 +222,17 @@
       end
     end
 
+    it "stubs out Socket#read correctly" do
+      TCR.configure { |c|
+        c.hook_tcp_ports = [23]
+      }
+      TCR.use_cassette("spec/fixtures/starwars_telnet") do
+        sock = TCPSocket.open("towel.blinkenlights.nl", 23)
+        expect(sock.read.length).to_not be_zero
+        sock.close
+      end
+    end
+
     it "supports ssl sockets" do
       TCR.configure { |c| c.hook_tcp_ports = [443] }
       http = Net::HTTP.new("www.google.com", 443)