Skip to content

Comments

Update assignment_1.ipynb#1

Open
SainaAliabadi wants to merge 1 commit intomainfrom
assignment-1
Open

Update assignment_1.ipynb#1
SainaAliabadi wants to merge 1 commit intomainfrom
assignment-1

Conversation

@SainaAliabadi
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Ran some code in a Jupiter notebook and modified them.

What did you learn from the changes you have made?

About KNN, about the test set and the training data set, and how to use cross-validation to compare these two.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

No

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes!

How were these changes tested?

For example, I wasn't sure about some exact code, so I searched on the internet to find out about the "drop" code.

A reference to a related issue in your repository (if applicable)

I googled it. What is the code to exclude a variable from the "shape"

Checklist

  • [ x] I can confirm that my changes are working as intended

PatelVishakh

This comment was marked as resolved.

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1: Complete. Great work!
Suggested Changes:

Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).

Q2)I)The more concise explanation is that variables with large scales can cause the model bias towards only being influenced by those variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants