[SYNPY-1653] Create RecordSet, Grid, and CurationTask classes #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n creation documentation
jaymedina
reviewed
Sep 26, 2025
| try: | ||
| item = loop.run_until_complete(async_gen.__anext__()) | ||
| yield item | ||
| except StopAsyncIteration: |
There was a problem hiding this comment.
Could this try/except loop break for other reasons except StopAsyncIteration? Does it matter that there's no cleanup after the break here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually covers SYNPY-1653 and SYNPY-1655
Problem:
Solution:
Testing:
Unit tests
Integration tests
Did manual testing during development, but needs more comprehensive testing