Repository navigation
fix(dataset): UnboundLocalError in CustomDatasetPath (preprocessed_mel) - #1338
Closed
rudycelekli wants to merge 1 commit into
Closed
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
load_dataset(dataset_type="CustomDatasetPath") -- a documented option for passing a full path to a preprocessed dataset -- passed preprocessed_mel=preprocessed_mel to CustomDataset, but that name is only assigned in the "CustomDataset" branch. So the CustomDatasetPath path raised UnboundLocalError and was unusable. It loads raw audio, so set preprocessed_mel = False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
load_dataset(..., dataset_type="CustomDatasetPath")— a documented option (docstring: "CustomDatasetPath if you just want to pass the full path to a preprocessed dataset") — raisesUnboundLocalErrorimmediately:preprocessed_melis only assigned inside the"CustomDataset"branch (asFalse/Truedepending onaudio_type). In theCustomDatasetPathbranch it's never set, so the whole option is dead —UnboundLocalError: cannot access local variable 'preprocessed_mel'.Fix
This branch loads raw audio, so set
preprocessed_mel = Falsebefore constructingCustomDataset.