-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원가입 시 프로필 이미지 업로드 및 S3 url 변수 분리 및 회원가입 로직 수정 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseokkim
reviewed
Aug 11, 2024
src/main/java/swm/betterlife/antifragile/domain/auth/service/AuthService.java
Show resolved
Hide resolved
junseokkim
reviewed
Aug 11, 2024
src/main/java/swm/betterlife/antifragile/domain/member/service/MemberService.java
Show resolved
Hide resolved
junseokkim
reviewed
Aug 11, 2024
src/main/java/swm/betterlife/antifragile/domain/member/dto/response/MemberDetailResponse.java
Outdated
Show resolved
Hide resolved
junseokkim
reviewed
Aug 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
업로드랑 수정, 삭제 다 테스트해서 된 거면 코멘트만 수정하면 될듯?
liontting
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
준석이 코멘트만 확인하면 될 듯 합니다! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.