Skip to content

Fixes for Firework Packages #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcalabro wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixes for Firework Packages #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
521c615
Updating Object Variables To Handle Float objects
bcalabro Dec 11, 2025
4b4320e
Update and cleanup base firework code
bcalabro Dec 11, 2025
563a436
Updated the firework show (packaged fireworks) code
bcalabro Dec 11, 2025
1d08982
Fix typo with sui listBox --> listbox
bcalabro Dec 11, 2025
9c8aa30
Fix typo with sui listBox --> listbox
bcalabro Dec 11, 2025
368a72c
Additional SUI fixes
bcalabro Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions sku.0/sys.server/compiled/game/script/base_class.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,19 +1870,16 @@ public static float[] getFloatArrayObjVar(obj_id object, String name)
* @param name the objvar name to search for
* @return the float array, or null if not found
*/
public static Vector getResizeableFloatArrayObjVar(obj_id object, String name)
{
public static Vector getResizeableFloatArrayObjVar(obj_id object, String name) {
float[] array = getFloatArrayObjVar(object, name);
if (array != null)
{
/*
if (array != null) {
Float[] newArray = new Float[array.length];
for ( int i = 0; i < array.length; ++i )
newArray[i] = new Float(array[i]);
for (int i = 0; i < array.length; ++i) {
newArray[i] = Float.valueOf(array[i]);
}
return new Vector(Arrays.asList(newArray));
*/
return new Vector(Arrays.asList(array));
}

return null;
}
/**
Expand Down Expand Up @@ -2609,6 +2606,8 @@ else if (data instanceof Float)
return setObjVar(object, name, ((Float)data).floatValue());
else if (data instanceof float[])
return setObjVar(object, name, (float[])data);
else if (data instanceof Float[])
return setObjVar(object, name, (Float[]) data);
if (data instanceof Boolean)
return setObjVar(object, name, ((Boolean)data).booleanValue());
else if (data instanceof boolean[])
Expand Down Expand Up @@ -26873,3 +26872,4 @@ public static boolean isInAdminTable(obj_id player) throws InterruptedException
}

} // class base_class

Loading