Fixes for Firework Packages #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to handle capital F Float objects for the Fireworks packages to work properly.
Contributor
Author
|
I've fixed the Firework packages with the help of Noxon from SWG Nexus! The issue was that the object variables were using capital "F" floats and needed some rewriting in the base class to handle those kinds of variable arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to handle capital F Float objects for the Fireworks packages to work properly.
Updated logic for Fireworks packages to fix the issue where packages could not fire off each firework due to a Float timing issue not being handled correctly as the object variables.