This repository was archived by the owner on May 29, 2020. It is now read-only.
Sourcery refactored master branch #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| return False | ||
| else: | ||
| return False | ||
| return bool(e.isdigit()) |
There was a problem hiding this comment.
Function DataScreen.only_numeric_input refactored with the following changes:
- Merge duplicate blocks in conditional
- Simplify conditional into return statement
| return True | ||
| else: | ||
| return False | ||
| return bool(e.isdigit() or not e.isdigit() and e == "") |
There was a problem hiding this comment.
Function FirstScreen.only_numeric_input refactored with the following changes:
- Merge duplicate blocks in conditional
- Simplify conditional into return statement
| return True | ||
| else: | ||
| return False | ||
| return bool(e.isdigit() or not e.isdigit() and e == "") |
There was a problem hiding this comment.
Function FirstScreen.only_numeric_input refactored with the following changes:
- Merge duplicate blocks in conditional
- Simplify conditional into return statement
Comment on lines
-198
to
+193
| if e.isdigit(): | ||
| return True | ||
| elif e == "": | ||
| return True | ||
| else: | ||
| return False | ||
| return bool(e.isdigit() or not e.isdigit() and e == "") |
There was a problem hiding this comment.
Function SecondScreen.only_numeric_input refactored with the following changes:
- Merge duplicate blocks in conditional
- Simplify conditional into return statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: