Add version constraints to gemspec #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed, because net-ssh 3.1.0beta1 onwards broke channels (or at least, in the way we use them with net-ssh-gateway). (cherry picked from commit 6377be3)
|
+1 |
Author
|
This should fix https://trello.com/c/s9rAxq0j and unblock https://trello.com/c/3PR66srj |
Author
|
@vmoravec Would be great if you could review this ASAP, since it's blocking completion of https://trello.com/c/3PR66srj which team Grapes been trying to complete for 4 sprints now :-) |
Member
|
+1 (but I've not tested it) |
|
+1 if it solves the problem with the net-ssh channels. I addressed that problem by restricting their use in CI (if cct is run on admin node) in #52, but the constraints are needed in gemspec anyway, thanks. |
This was referenced Apr 7, 2016
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed, because net-ssh 3.1.0beta1 onwards broke channels (or at least, in the way we use them with net-ssh-gateway).
(cherry picked from commit 6377be3)