Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First functional beta #9

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

First functional beta #9

wants to merge 86 commits into from

Conversation

robertohueso
Copy link
Member

Everything's kinda working, there's a lot to improve but this is functional. 🎉

JaviBF92 and others added 30 commits November 14, 2016 16:47
@JaviBF92
Configparser library added; now the config.ini file contains the conf…
3cefe69 
…iguration info; gitignore updated

Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Added to DB new tables and initialization for future permission roles
5cf614c 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Code modularization. Now repository.py will contain the DataBase func…
d3da1a9 
…tions

Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Name of function add_to changed; wrong module import changed
dddc7fb 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Function empty_event edited to accept date as an optional parameter
0d9f067 
Signed-off-by: JaviBF92 <[email protected]>
@ManuelLR
Modularized code to messaging & ancillary_methods
1ef2ec3
@ManuelLR
Added permission check to execute messages
909dc63
@ManuelLR
Permissions group handling (list, create and help)
1e33e62
@ManuelLR
Added class conversation_session
74fab26
@JaviBF92
periodicCheck now uses empty_event function
408dd85 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Merge branch 'Develop' of https://github.com/SUGUS-GNULinux/SugusBot …
f0972c0 
…into Develop
@JaviBF92
periodicCheck function fixed
ac09e7c 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
log file edition fixed
c08424d 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Addition of spaces and some names changed
fe60717 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Function add_user_permission added to repository.py; changes in datab…
3e93bf8 
…ase constraints; some changes in functions to improve behavior and cursor closing

Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Events commands added & optimizations in sugusbot.py
e14dde2 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
auxiliar function show_list simplified
128afc7 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Deprecated emojis changed for emoji library
176d909 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
emoji library added to requirements
9eb4293 
Signed-off-by: JaviBF92 <[email protected]>
@ManuelLR
Added ban users with no username to be added to a list (Solved issue #2)
968289f
@JaviBF92
added to show_list function one-value list treatment
bc4eac7 
Signed-off-by: JaviBF92 <[email protected]>
@JaviBF92
Parameters of some show_list callings changed (issue #6 fixed)
9ef5a04 
Signed-off-by: JaviBF92 <[email protected]>
@ManuelLR
Added rel_user_event
376ba86
@ManuelLR
Merge branch 'Develop'
c8aa08f
@ManuelLR
Improve show_list
97b1513
@ManuelLR
Update remove_from_event
fee0d91
@ManuelLR
Empty_event & periodic_check updated
78b01ef
@ManuelLR
Added Auto update user data
e18e24f
@JaviBF92
Merge pull request #7 from SUGUS-GNULinux/rel_user_event
66dfa9d 
Rel user event
@JaviBF92
Some fixes included
4de732e 
Signed-off-by: JaviBF92 <[email protected]>
@robertohueso robertohueso requested a review from ManuelLR October 7, 2017 16:16
@ManuelLR ManuelLR requested review from JaviBF92 and robgc October 7, 2017 16:16
@ManuelLR
Copy link
Member

ManuelLR commented Oct 7, 2017 •
edited
Loading

Os recuerdo que esta rama del bot se despliega automáticamente tras cada commit en @Sugus_ofset_bot

@robertohueso
Copy link
Member Author

El "quien come" funciona y el bot parece que no se cae, al menos eso nos puede servir a partir del lunes

@robgc
Copy link

robgc commented Feb 6, 2018

Parece que las partes básicas funcionan, aunque hay que replantear la parte de eventos.

@ManuelLR
Copy link
Member

ManuelLR commented Feb 6, 2018

Totalmente de acuerdo. Que sugieres para la parte de eventos?

@robgc
Copy link

robgc commented Feb 6, 2018

Yo veo como posibles mejoras lo siguiente:

  • Hacer la creación de un evento más interactiva, no como un comando, sino como una serie de pasos en la que el usuario respondiese a preguntas del bot.
  • Usar los widgets de botones para fechas, pudiendo establecer límites en la entrada (no permitir días anteriores, no pasar de día...).
  • Añadir límites de usuarios a un evento.

Y en líneas generales se podría hacer un rework de todo el bot y evitar los comándos clásicos ("/comando")

@robgc robgc removed the request for review from JaviBF92 February 6, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robgc robgc robgc approved these changes

@ManuelLR ManuelLR Awaiting requested review from ManuelLR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertohueso @ManuelLR @robgc @JaviBF92 @rarellano