-
Notifications
You must be signed in to change notification settings - Fork 65
New Home Page #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Home Page #842
Conversation
Could you provide a picture...? |
I cannot test what it looks like but maybe you can. I know it looks good... |
How did you make it if you didnt test it? And no i cannot provide one since i dont have access to a pc rn |
Wait somethings wrong.. |
Possible ideas
|
blacks more readable on orange |
|
View Image Black on orange  White on orange |
The view all button and the box header should both be black. My original code was contrast tested |
Thats weird |
No, you're right. I was just showcasing that the color it currently is should be darker (black) which you already noted as it's currently a shade of gray which looks off. So, just change the color to black and from a color standpoint it should be good 👍 |
ok I see its gray. |
I had put color:black i dont see it anymore.. |
Done! See line 19 & 16 |
Is that done? |
I think this could work as an experimentational feature for now. Would need others opinions |
Like I said, it needs work! But it's definitely a start... |
@MaterArc Hmm.. Ok thanks. |
Can we please approve this PR quickly. I would like to role out these features now while I work to add more. |
Would need rg approval If we were to merge this rn it should be a beta feature |
Thanks for responding. Yes, BETA feature is fine with me! |
Did you check out the profile page styles. |
I cannot rn, in the future please provide pictures when possible |
Hmm.. Ok.
Don't see many what? |
At the moment, this userstyle is rather niche and would only benefit a small margin of users. However, if it was customizable, it would be much more useful to more users. |
@rgantzos Got it. What would you like to add as customizable features. I would expect the dark/light themes. But what else? Also I didn't find @STForScratch/website-developers but I did find website, website2, etc.. |
Ok! Thanks! |
@MaterArc I need to add a toggle switch to the feature JSON, which I think I have done correctly. The only problem is how I am supposed to get that as a CSS variable that allows me to change the Dark/Light mode of the background |
You're going to have to use some JavaScript |
@MaterArc do you know exactly what I need to do? |
Also I can see that there are merge conflicts and I don't quite know how to fix those. Maybe one of you can help me with that. |
"scripts": [{"file": "scratch-www.js", "runOn": "/"}, { "file": "scratch-profile.js", "runOn": "/users/*" }], | ||
"tags": ["Theme", "New"], | ||
"type": ["Website", "Editor"], | ||
"options": [{ "id": "theme", "name": "Mode", "type": 0 }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have an option yet it is never referenced anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See scratch-www.js line 4:
ScratchTools.Storage.theme
Is that how you reference an option, or do I do something different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgantzos Also, instead of integrating dark mode into my "tool" why can't I (or someone else) just make another dark mode tool that is compatible with this?
Hi, @rgantzos @cally-jt @MaterArc, This PR is left open and unmerged for more than a month. If this PR is not required, not well-designed, not "welcome" to this extension, or just simple not detailed enough, I can close this. Let me know if you still believe that this PR can be merged to the extension. |
I will make more styles soon but for now its just a nicer home page.