-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added summary stat performance test #506
base: master
Are you sure you want to change the base?
Conversation
this unit test represents a performance issue the white paper algorithm implementation demonstrated. it's a very simple operation but necessary for computing summary statistics. |
Thanks Chris, we'll investigate. |
@hkaiser updated with another edge case - would ya'll prefer if these tests were split out across multiple files? |
@ct-clmsn I think we're still fine, thanks! |
@ct-clmsn we'll have to get back to this once @rtohid and @justwagle have fixed the |
@hkaiser no problem; thanks! |
@ct-clmsn Actually, closer investigation shows, that the bad performance is caused by the (bad) PhySL code generated. Let's see how it will fare once the frontend etc. has been fixed. |
@hkaiser apologies on my end for not taking time to vet the PhySL layer. I'll add that to my code review process. |
performance test added - accessing an array that stores indices, used for a 2nd matrix/array look up, could use some performance tuning in phylanx. this test provides a python/numpy version and the phylanx version.