Open
Conversation
gurwls0122
approved these changes
May 26, 2024
Collaborator
gurwls0122
left a comment
There was a problem hiding this comment.
고생하셨습니다! AOP를 이용해서 낙관락을 구현하여 재사용성도 좋아보이네요!
최대 시도횟수와 재시도 delay에 들어가는 상수값을 정하는 방법론이나 테스트도 나중에 같이 해보면 좋을것 같네요!~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Desciption