Open
Conversation
- JpaRepository 대신 EntityManager 사용하여 의존성 제거, 코드 간결하게 수정 - 중복된 테스트케이스 삭제
gurwls0122
reviewed
May 26, 2024
Collaborator
gurwls0122
left a comment
gurwls0122
left a comment
There was a problem hiding this comment.
고생하셨습니다! 테스트 관련 리팩토링하는 일도 생각보다 훨씬 복잡하고 힘든 것 같네요!
너무 늦게 리뷰 작성해서 미안합니다..!
| public FormIdDto createForm(FormCreateDto request, LoginUserDto loginUser) { | ||
| log.debug("Create Form: contents: {}, loginUser: {}", request, loginUser.id()); | ||
|
|
||
| return formCreateService.execute(request, loginUser); |
Collaborator
There was a problem hiding this comment.
execute에서 리턴을 받은 후 formResponseMapper로 변환하는 것이 어떠신가요?
| @@ -0,0 +1,16 @@ | |||
| package com.formssafe.util; | |||
Collaborator
There was a problem hiding this comment.
Assertion을 util로 빼놓은 점이 참신하고 좋네요! 계속 반복코드 작성해서 힘들었는데 인싸이트 배워갑니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Desciption