Use C++ templates to create specialization of Interpreter loop #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I used macros, because I couldn’t figure out how to get this to work with templates. Turns out the template parameter shouldn’t be a function parameter, which I for some reason thought would be needed before. Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I used macros, because I couldn’t figure out how to get C++ templates to work so that we have the interpreter loop specialized for bytecode tracing and without.
Turns out the template parameter shouldn’t be a function parameter, which I for some reason thought would be needed before.
And with this, we can rely on C++ templates to avoid any run-time cost for supporting tracing.
As before, there are two compilations of the bytecode loop one with and one without tracing.