Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of inlined args and some bytecodes #61

Merged
merged 8 commits into from
Feb 22, 2025

Conversation

smarr
Copy link
Member

@smarr smarr commented Feb 22, 2025

The inlining logic did not yet account for the block argument of #to:do: being turned into a local variable.

This PR uses the existing lexical scope and mgenc to look up the matching new version of the previous argument.

It also adds handling for DUP_SECOND in AdaptAfterOuterInlined and fixes the adapting of INC_FIELD_PUSH and INC_FIELD which do not have explicit context arguments.

…t arguments to locals when needed

Signed-off-by: Stefan Marr <[email protected]>
…to be adapted

This is specific to SOM++, where we really just walk the context chain instead of counting.

Signed-off-by: Stefan Marr <[email protected]>
@smarr smarr merged commit a662c18 into SOM-st:master Feb 22, 2025
19 checks passed
@smarr smarr deleted the fix-handling-of-inlined-args branch February 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant