Implement inlining for #ifNil:*, #ifNotNil:* selectors #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
changed the title
smarr
added a commit
that referenced
this pull request
Feb 20, 2025
Adopts the changes of SOM-st/SOM#123 and SOM-st/SOM#124. This does not add any changes in SOM++ itself though. They are separate in #59.
Signed-off-by: Stefan Marr <[email protected]>
Still not complete, but now supports the different types of invokables and some more bytecodes. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
It can allocate, and the IfNil benchmark runs out of memory. Ooops. Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the existing support for inlining of
ifTrue:etc to also supportifNil:etc.The inlining logic is mostly unchanged, just generalized to support the different bytecodes.
The new bytecodes are, incl. JUMP2 omitted here:
The bytecodes check for
niland may keep the top element (TOP_TOPto be read as top is set to top), or pop it on success.The PR also resolves some lint issues and improve the disassembler.
When integers are not tagged, BC_INC now needs a GC check, to avoid running out of memory on the
IfNilbenchmark.