Skip to content

Issue Fix - #450

Merged
IbrahimIjai merged 2 commits into
SO4-Markets:mainfrom
JSE19:main
Jul 29, 2026
Merged

Issue Fix#450
IbrahimIjai merged 2 commits into
SO4-Markets:mainfrom
JSE19:main

Conversation

@JSE19

@JSE19 JSE19 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description:
DS-031 — Build AppShell and PageHeader primitives

  • New AppShell component with full (viewport-filling for Trade) and constrained (max-width container) layout variants
  • New PageHeader component with slots for title, description, actions, metadata, tabs, and breadcrumbs
  • Header actions stack below title on mobile for reachability; all slots are route-agnostic
  • Gallery page demos + unit tests for both layout modes

DS-032 — Refactor Navbar onto shared navigation primitives

  • Extracted shared SiteLogo, HamburgerButton, and useMobileMenu hook (with Escape key support) into apps/web/src/ui/nav/primitives.tsx
  • Both Navbar (app/landing) and Nav (landing standalone) now import from shared primitives — logo SVGs, hamburger icons, and class strings are no longer duplicated
  • Active navigation is programmatically indicated: app via TanStack Router activeProps, landing via useLocation().pathname (replacing hardcoded boolean flag)
  • Mobile menu closes on navigation click and on Escape key press

DS-033 — Build a Breadcrumb component

  • New Breadcrumb compound component with BreadcrumbItem, BreadcrumbLink, BreadcrumbSeparator, and BreadcrumbEllipsis sub-components
  • Semantic wrapping an
    1. aria-current="page" on the current item via isCurrent prop
    2. Long-path collapse via maxItems prop — first + ellipsis + last
    3. Unit tests cover semantics, truncation, and accessibility

Closes #418
Closes #419
Closes #420

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

@JSE19 is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@JSE19 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai
IbrahimIjai merged commit 10d419d into SO4-Markets:main Jul 29, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DS-033: Build a Breadcrumb component DS-032: Refactor Navbar onto shared navigation primitives DS-031: Build AppShell and PageHeader primitives

2 participants