[pull] main from millionco:main - #231
Merged
Merged
Conversation
* fix: remove @expo/metro-config from redundant dependency check The rule incorrectly flagged @expo/metro-config as redundant, suggesting to use expo/metro-config instead. While expo does re-export the main entry point, it does NOT re-export subpaths like babel-transformer. Projects that import @expo/metro-config/babel-transformer (documented by Expo for extending the Babel transformer) cannot use expo/metro-config/ babel-transformer as it does not exist. The suggested fix is impossible to follow for subpath imports. Since the static check cannot distinguish between main entry and subpath usage, and Expo SDK upgrades keep both packages in lockstep, the version drift risk is minimal. Removing this entry prevents false positives. Closes #1726 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * chore: add changeset for expo/metro-config fix Co-authored-by: Skosh <skoshx@users.noreply.github.com> * fix: keep required Expo Metro config subpaths --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden@million.dev>
* fix(rn-no-raw-text): exempt fbt children of text-wrapping custom components The rule now checks auto-detected and imported text wrappers when evaluating transparent wrapper boundaries, not just built-in text components. This fixes a false positive where `<fbt>` (a compile-time translation tag) inside a custom component that renders `<Text>` was incorrectly reported as a crash. Closes #1722 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * chore: add changeset for #1722 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * fix(rn-no-raw-text): verify fbt text wrappers --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden@million.dev>
* fix(rn-no-raw-text): suppress diagnostic for components returning only transparent text wrappers Components whose entire return value is a transparent text wrapper (<fbt>, <fbs>, or <Fragment>) are now classified as text-producing components. This prevents false positives when such components are consumed inside <Text> elements. Fixes #1729 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test(rn-no-raw-text): add regression tests for issue #1729 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * chore: add changeset for issue #1729 fix Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test: update regression tests to reflect #1729 fix limitation Co-authored-by: Skosh <skoshx@users.noreply.github.com> * fix: handle direct fbt component returns --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden@million.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )