[pull] preview from makeplane:preview - #105
Merged
Merged
Conversation
* chore: remove unused banner components from web application Deleted the following banner components as they are no longer needed: - AuthBanner - BulkOperationsUpgradeBanner - ContentLimitBanner - IntegrationAndImportExportBanner This cleanup helps streamline the codebase and remove redundant files. * refactor: update banner imports and usage across multiple components Replaced instances of the old banner component from @plane/propel with the new one from @makeplane/propel/components in various files. Adjusted properties and structure for consistency, including changes to the ArchivedIssueDetailsPage, DevErrorComponent, AuthRoot, and ResetPasswordForm. This update enhances the UI consistency and aligns with the recent component migration. * refactor: update icon imports in ArchivedIssueDetailsPage and DevErrorComponent Replaced the old icon components with new ones from @makeplane/propel/icons in the ArchivedIssueDetailsPage and DevErrorComponent. This change enhances visual consistency across the application by standardizing the icon usage in banner notifications. * fix: enhance accessibility for Upgrade to One link in IssueBulkOperationsRoot Updated the anchor element for the "Upgrade to One" button to include an aria-label for improved accessibility. This change ensures that screen readers can properly announce the purpose of the link, enhancing the user experience for individuals relying on assistive technologies. * feat(i18n): integrate translation support in multiple components Added translation functionality to the ArchivedIssueDetailsPage, WorkspaceIntegrationsPage, and PageRoot components. Updated banner titles and headings to utilize localized strings, enhancing the user experience for non-English speakers. This change improves accessibility and consistency across the application by leveraging the i18n framework. * feat(i18n): add page content limit banners and archive messages across multiple languages Introduced new localized messages for the "page content limit" banner and updated archive notifications in various language files. This enhancement improves user experience by providing clear guidance when content limits are reached and when work items are archived, ensuring consistency and accessibility across the application. * refactor: update password strength banner implementation in AuthPasswordForm Replaced the custom banner implementation with the new Banner component from @makeplane/propel/components. This change simplifies the code and enhances consistency in the user interface by utilizing the standardized Banner component for displaying password strength messages during sign-up. * refactor: replace AnchorButton with Button in IssueBulkOperationsRoot Updated the IssueBulkOperationsRoot component to replace the AnchorButton with the new Button component from @makeplane/propel/components. This change enhances the UI consistency and aligns with the recent component migration, while also adding a stretch property for improved layout flexibility. * fix: enhance accessibility of Banner component in AuthRoot and ResetPasswordForm Added role="alert" to the Banner component in both AuthRoot and ResetPasswordForm to improve accessibility for users relying on assistive technologies. This change ensures that error messages are announced appropriately, enhancing the overall user experience.
…9743) * refactor: update collapsible components to use @makeplane/propel - Migrate collapsible components in issue detail widgets (attachments, links, relations, sub-issues) from @plane/ui to @makeplane/propel. - Adjust props and structure for consistency with new collapsible implementation. - Enhance title components to integrate action buttons and improve accessibility. - Refactor related components to streamline imports and improve code clarity. * refactor: enhance icon rendering in relations component - Update the icon rendering logic in the RelationsCollapsibleContent component to apply additional styling using the cn utility. - Ensure that icons are wrapped in a styled span for consistent presentation and alignment. * refactor: adjust layout of RelationIssueList in RelationsCollapsibleContent - Wrap RelationIssueList in a div to cancel the nested Collapsible's panel inset, ensuring proper alignment under the outer Relations collapsible. - Improve visual consistency by preventing stacking of insets in the UI. * refactor: improve layout of pending invitations in WorkspaceMembersList - Wrap the Collapsible component for pending invitations in a div to enhance layout and spacing. - Ensure consistent visual presentation by adjusting the structure of the component. * refactor: simplify onOpenChange handlers in collapsible components - Update the onOpenChange prop in SubIssuesListGroup and WorkspaceMembersList to directly use the state setter function, improving code clarity and reducing unnecessary function wrapping. * refactor: simplify mapping of work item IDs in SubIssuesListGroup - Remove optional chaining from the mapping of workItemIds to enhance code clarity and ensure consistent handling of the array. * refactor: adjust padding in attachment list item and link list components - Update padding in the attachment list item for improved spacing and alignment. - Remove unnecessary padding from the link list component to streamline layout. * chore: update @makeplane/propel version in lockfile to 0.3.0 Align the pnpm-lock.yaml file to reflect the updated version of @makeplane/propel from 0.2.0 to 0.3.0 for consistency across importers.
* chore: update @makeplane/propel version in pnpm-lock.yaml to 0.3.0 * refactor: replace TextArea usage with TextAreaGroup in forms Updated various forms across the application to utilize TextAreaGroup for better structure and error handling. This change enhances the consistency of the description fields in forms, ensuring they are wrapped in a Field component for validation and styling. The updates were made in the CreateApiTokenForm, CycleForm, ModuleForm, ProjectDetailsForm, and others. * refactor: enhance TextArea components across forms with auto-resize and maxRows Updated various forms to improve the TextArea components by adding auto-resize functionality and setting a maximum number of rows. This change enhances user experience by allowing better visibility and management of text input across the CreateApiTokenForm, CycleForm, ModuleForm, ProjectDetailsForm, and others. * refactor: remove unnecessary containerClassName from TextArea components Removed the redundant containerClassName="-ml-3" from TextArea components in InboxIssueMainContent, IssueMainContent, and PeekOverviewIssueDetails to streamline the code and improve consistency across the application. * refactor: remove maxRows from TextArea components in Cycle and Module analytics sidebars Updated the TextArea components in CycleSidebarDetails and ModuleAnalyticsSidebar to remove the maxRows property, allowing for unrestricted text input. This change enhances the user experience by providing more flexibility in text entry. * refactor: remove className prop from IssueTitleInput component Eliminated the optional className prop from the IssueTitleInputProps interface to streamline the component's API and improve consistency across the application. * refactor: remove PageEditorTitle component to streamline editor functionality Deleted the PageEditorTitle component from the editor, simplifying the codebase and enhancing maintainability. This change aligns with ongoing efforts to improve component structure and reduce redundancy in the application. * fix: ensure description field in StateForm defaults to an empty string Updated the description field in the StateForm component to default to an empty string when no value is provided. This change improves the handling of form data and ensures consistent behavior in the input field. * refactor: simplify IssueTitleInput component by removing TextAreaGroup Updated the IssueTitleInput component to eliminate the TextAreaGroup wrapper, replacing it with a div for improved structure. Additionally, adjusted the TextArea properties to set the surface to "inline" and changed the rows to 1, enhancing the input's appearance and functionality. * refactor: streamline description rendering in ModuleAnalyticsSidebar Removed redundant wrapping of the description TextArea in the ModuleAnalyticsSidebar component, simplifying the code while maintaining functionality. This change enhances readability and consistency in the component's structure.
* refactor: migrate web Tabs to @makeplane/propel Replace in-repo @plane/propel/tabs with @makeplane/propel/components/tabs in analytics, the image picker popover, and the page navigation pane. Published Tabs omit className on Tabs and TabsPanel, so fill-height layouts use a flex/grid wrapper instead. Tabs.Trigger, Tabs.Content, and Tabs.Indicator become Tab, TabsList, and TabsPanel. * fix: restore cover picker tab strip to full width Published TabsList is inline-flex, so Images/Upload hugged content instead of spanning the 36rem panel. Stretch the list to the previous full-width segmented bar. * chore: sync apps/space lockfile to @makeplane/propel 0.3.0 preview's lockfile still resolved apps/space to 0.2.0 after the catalog bump, so pnpm install --frozen-lockfile failed in CI. * fix: restore cover picker tab panel mt-3 p-3 spacing Match the previous scroll wrapper inset so thumbnail grid sizing stays aligned with the 36rem picker layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )