[pull] preview from makeplane:preview - #103
Merged
Merged
Conversation
Bumps the npm_and_yarn group with 1 update in the / directory: [sanitize-html](https://github.com/apostrophecms/apostrophe/tree/HEAD/packages/sanitize-html). Updates `sanitize-html` from 2.17.5 to 2.17.7 - [Changelog](https://github.com/apostrophecms/apostrophe/blob/main/packages/sanitize-html/CHANGELOG.md) - [Commits](https://github.com/apostrophecms/apostrophe/commits/HEAD/packages/sanitize-html) --- updated-dependencies: - dependency-name: sanitize-html dependency-version: 2.17.7 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: migrate package icons to @makeplane/propel Replace confirmed icon symbols in packages/editor, packages/propel, packages/ui and packages/utils with their audited @makeplane/propel/icons targets, including the relative legacy icon imports inside packages/propel/src. Add the dependency to all four workspaces. Widen the icon component types that were pinned to LucideIcon so both Lucide and Propel icons satisfy them: the editor menu items, editor constants, custom image utils, alignment selector, the ui alert modal variants, and the link icon matchers in utils. Each only renders the icon as a component, and the matcher list still mixes both sources. Two files are deliberately left alone. The emoji-icon-picker directory is out of scope, and icons/priority-icon.tsx dispatches one shared size prop across four still-unresolved Lucide icons, so migrating only its urgent glyph would break that prop and mix fill with stroke. * fix: address icon migration review on packages Restore the 49 user-facing strings the identifier rename overwrote. The migration replaced every occurrence of a source symbol name, including ones inside string literals and JSX text, so editor toolbar labels, slash-command titles, image download tooltips and aria-labels, and the Storybook example labels all displayed icon component names. Drop strokeWidth from Propel icons; the generated glyphs paint with fill="currentColor" so the prop never changed weight. Pick StarFilled for the selected FavoriteStar. Lucide's Star with a fill utility was a solid star, and StarOutline is a ring path, so filling it does not reproduce that shape. Also correct six toolbar story tooltips that already read "Bullet ListLayoutIcon" on preview, from an earlier migration with the same over-broad rename. * fix: restore context-menu story labels after icon rename The mechanical icon rename also replaced JSX text children that matched old lucide identifiers (Edit, Download, Share, Archive). Restore the 13 user-facing labels in the context-menu stories. * chore: align lockfile @makeplane/propel importers to 0.3.0 The preview merge left editor, propel, ui, and utils resolved to 0.2.0 while catalog is 0.3.0. Re-resolve those importers so the lockfile matches.
Corrects 'satifies' to 'satisfies' and 'Donot' to 'Do not' in code comments.
…ently dropping invalid ids (#9526) Work item create/update via the external API returned 200/201 even when assignees or labels didn't belong to the project, quietly filtering the invalid ids out with no error. Now raises the same kind of ValidationError already used for state/parent, matching the pattern of #9517.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )