Skip to content

[Snyk] Fix for 2 vulnerabilities #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SMSDAO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/tg-bot-starter/basic-tg-bot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": "next lint"
},
"dependencies": {
"@langchain/core": "^0.3.26",
"@langchain/core": "^1.1.14",
"@langchain/langgraph": "^0.2.36",
"@langchain/openai": "^0.3.16",
"grammy": "^1.33.0",
Expand All @@ -18,7 +18,7 @@
"prebuilt": "link:@langchain/langgraph/prebuilt",
"react": "^19.2.0",
"react-dom": "^19.0.0",
"solana-agent-kit": "^1.3.0"
"solana-agent-kit": "^2.0.1"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json specifies "solana-agent-kit": "^2.0.1" but the lock file resolves to version 2.0.10. While this is normal behavior for caret ranges (^2.0.1 allows 2.0.10), the PR description states the upgrade is to fix vulnerabilities.

For clarity and to ensure reproducible builds that match security expectations, consider either:

  1. Updating the package.json to specify the exact version being tested: "solana-agent-kit": "^2.0.10"
  2. Or using a tilde range to be more conservative: "solana-agent-kit": "~2.0.1"

This ensures that the exact version that fixed the vulnerabilities is what gets installed.

Suggested change
"solana-agent-kit": "^2.0.1"
"solana-agent-kit": "^2.0.10"

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +21
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions fixing a Prototype Pollution vulnerability in axios (SNYK-JS-AXIOS-15252993), but the package.json and visible code don't show axios as a direct dependency. This suggests:

  1. Axios is a transitive dependency of the upgraded packages
  2. The vulnerability is being fixed through the dependency chain updates

However, the lock file shows axios was completely removed (it appeared in the old dependency tree but not in the new one). This is actually a good outcome - if axios was causing vulnerabilities and is no longer needed, removing it reduces the attack surface.

Verify that the functionality previously provided by axios (if any) is still working correctly after these updates.

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +21
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes major version updates that introduce breaking changes:

  1. @langchain/core: 0.3.26 → 1.1.24 (major version bump)
  2. solana-agent-kit: 1.3.0 → 2.0.10 (major version bump)

The Snyk metadata indicates isBreakingChange: true. While these updates fix critical security vulnerabilities (Prototype Pollution with score 828 and SSRF with score 541), the major version changes require careful verification:

  • The code imports HumanMessage from @langchain/core/messages and uses SolanaAgentKit and createSolanaTools from solana-agent-kit
  • These APIs may have changed between major versions
  • The application should be tested to ensure compatibility with the new versions before merging

Consider reviewing the changelog for both packages to understand the breaking changes and verify that the existing code is compatible with the new APIs.

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@types/node": "^20",
Expand Down
Loading