Skip to content
This repository was archived by the owner on Jun 10, 2022. It is now read-only.

Change cs's style and make js be oop#6

Open
shyenjian wants to merge 2 commits intoSHELTER-ZONE:masterfrom
shyenjian:master
Open

Change cs's style and make js be oop#6
shyenjian wants to merge 2 commits intoSHELTER-ZONE:masterfrom
shyenjian:master

Conversation

@shyenjian
Copy link

No description provided.

Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes involved in C#, are basically invalid as the method names in C#, as a naming convention, should be PascalCase.

@HTGAzureX1212
Copy link
Contributor

Therefore I am fully against the commits on the C# part.

@HTGAzureX1212
Copy link
Contributor

All changes involved in C#, are basically invalid as the method names in C#, as a naming convention, should be PascalCase.

By that I mean the changes are against the naming convention.

@HTGAzureX1212 HTGAzureX1212 self-assigned this Sep 6, 2020
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming Conventions fixed.

C#_Cert.cs Outdated
}

public void Run(Func<string, string> function)
public void run(Func<string, string> function)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid: Methods should be PascalCase under the C# Naming Convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method *names

C#_Cert.cs Outdated
}

public string GetPassword(string userID)
public string getPassword(string userID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid: Method names should be PascalCase under the C# Naming Convention.

C#_Cert.cs Outdated
}

public static long Encrypt(long number) =>
public static long encrypt(long number) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid: Method names should be PascalCase under the C# Naming Convention

C#_Cert.cs Outdated
Convert.ToInt64(CheckType(typeof(long), number)) >> 23 ^ 2333;

static string Solve(string token)
static string solve(string token)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid: Method names should be PascalCase under the C# Naming Convention.

@MiniAppleTheApple
Copy link

js is still not oop 🤔

@HTGAzureX1212
Copy link
Contributor

Where is class 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants