.env.example: Fix environment variable for reverse proxy base url #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently set up Abrechnung using docker compose and stumbled upon a small discrepancy in .env.example (because registration emails included a link to localhost).
As far as I can tell, the enviroment variables
ABRECHNUNG_SERVICE__URLakaservice.urlandABRECHNUNG_SERVICE__BASE_URLakaservice.base_urlare not used.Instead it should be
ABRECHNUNG_API__BASE_URLakaapi.base_url- as used in abrechnung/mailer.py and defined in abrechnung/config.py (using import from sftkit sftkit/http/_config.py). I believe this small oversight might stem from v1.0.0 which changed the config definition.This PR changes .env.example accordingly.
Additional thought
The correctness and necessity of ports in the config should probably also be checked. I wouldn't notice as I'm running Abrechnung behind a reverse proxy using docker and it might be different for other setups. If the port could be omitted from the config, it would improve the clarity of the .env file a lot. Unless I'm missing something (maybe the Prometheus integration), I believe the only relevant port for a docker deployment is the default
:80on thefrontendcontainer as that is all that should be needed for configuring the reverse proxy.If I've missed anything, please let me know.