Recommend the simplest possible configuration and build commands #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
simplify_build_instructions
branch
from
7ab97ea to
1880956
Compare
Once users wish to start customizing their build by potentially enabling optimizations, then they can learn about such differences. For now it's not useful to add this extra branch in the instructions. Let's keep it simple.
ChrisThrasher
force-pushed
the
simplify_build_instructions
branch
from
1880956 to
a8638c1
Compare
|
So now they have to install and understand ninja instead of using the default tool chain? IMHO it's reasonable enough to learn the very basics upfront. Not like knowing source and type is that complicated 😄 |
No not at all. Quite the opposite. These commands mean CMake will choose the default toolchain for their platform. On Windows that means MSVC + VS Solutions. https://github.com/SFML/cmake-sfml-project/actions/runs/9922990212/job/27412660246#step:4:5 We already run these commands in CI. MSVC + MS build is picked. |
eXpl0it3r
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once users wish to start customizing their build by potentially enabling optimizations, then they can learn about such differences. For now it's not useful to add this extra branch in the instructions. Let's keep it simple.
You can use a multi-config generator on Linux and macOS via Ninja-MultiConfig and you can also use a single-config generator on Windows via Clang and Ninja or minGW and Makefiles. It's not reasonable to expect first time CMake users to understand this.