fixed windows file errors and java check#126
Open
nathanhilbert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading the tutorial file in formhub, I was getting a permission denied to my temp directory. This was because pyxform was creating and opening a tempfile, then trying to open it again. This works fine in Linux, but not so great in Windows (https://docs.python.org/2/library/tempfile.html#tempfile.NamedTemporaryFile). I also noticed a "which" command, which always returns true in Windows based on the logic. Checking for the os name and using "where", then checking for the INFO error will work better.