feat(sekoiaio): add custom status and verdict to trigger and action o…#2073
Open
alexandreLavenant wants to merge 1 commit intodevelopfrom
Open
feat(sekoiaio): add custom status and verdict to trigger and action o…#2073alexandreLavenant wants to merge 1 commit intodevelopfrom
alexandreLavenant wants to merge 1 commit intodevelopfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExpose alert custom_status and verdict fields in both the alert trigger payload and related alert actions so downstream consumers can access and manipulate these attributes. ER diagram for alert, custom_status, and verdicterDiagram
ALERT {
string id
string created_at
string urgency
}
STATUS {
string uuid
string name
}
CUSTOM_STATUS {
string uuid
string name
}
VERDICT {
string uuid
string name
}
ALERT ||--o| STATUS : has_status
ALERT ||--o| CUSTOM_STATUS : has_custom_status
ALERT ||--o| VERDICT : has_verdict
Class diagram for updated alert payload structureclassDiagram
class AlertPayload {
+string created_at
+string urgency
+object entity
}
class Status {
+string name
+string uuid
}
class CustomStatus {
+string name
+string uuid
}
class Verdict {
+string name
+string uuid
}
AlertPayload *-- Status : status
AlertPayload *-- CustomStatus : custom_status
AlertPayload *-- Verdict : verdict
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The mapping for
custom_statusandverdictuses.get("label")whilestatususes.get("name"); if this is intentional due to the upstream schema, consider adding a brief code comment to clarify the difference and avoid future confusion. - The nested
alert.get(..., {}).get(...)pattern is now repeated forstatus,custom_status, andverdict; consider extracting a small helper to build these{name, uuid}dicts to reduce repetition and make the structure easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The mapping for `custom_status` and `verdict` uses `.get("label")` while `status` uses `.get("name")`; if this is intentional due to the upstream schema, consider adding a brief code comment to clarify the difference and avoid future confusion.
- The nested `alert.get(..., {}).get(...)` pattern is now repeated for `status`, `custom_status`, and `verdict`; consider extracting a small helper to build these `{name, uuid}` dicts to reduce repetition and make the structure easier to maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add custom status and verdict properties to trigger and action of the alert
Summary by Sourcery
New Features: