Open
Conversation
Contributor
Reviewer's GuideSplits the original Check Point automation into two modules by renaming and retargeting the existing module as Check Point Harmony, and introducing a new, minimal Check Point Quantum module with its own manifest and changelog. Class diagram for Check Point Harmony and Quantum automation modulesclassDiagram
class CheckPointHarmonyModule {
+string client_id
+string secret_key
+string authentication_url
+string base_url
+string description
+string name
+string uuid
+string slug
+string version
+string[] categories
}
class CheckPointQuantumModule {
+string description
+string name
+string uuid
+string slug
+string version
+string[] categories
+object configuration
}
class HarmonyConfigurationSchema {
+string client_id
+string secret_key
+string authentication_url
+string base_url
+string title
+string type
+string[] required
+string[] secrets
}
class QuantumConfigurationSchema {
+string title
+string type
+string[] required
}
CheckPointHarmonyModule --> HarmonyConfigurationSchema : uses
CheckPointQuantumModule --> QuantumConfigurationSchema : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- For the new Check Point Quantum module, consider defining any expected connection or configuration fields (e.g., URLs, credentials, or feature toggles) rather than leaving the
configuration.propertiesempty so consumers know how to parameterize it from the start.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the new Check Point Quantum module, consider defining any expected connection or configuration fields (e.g., URLs, credentials, or feature toggles) rather than leaving the `configuration.properties` empty so consumers know how to parameterize it from the start.
## Individual Comments
### Comment 1
<location> `CheckPointQuantum/manifest.json:4-5` </location>
<code_context>
+{
+ "configuration": {
+ "$schema": "http://json-schema.org/draft-07/schema#",
+ "properties": {},
+ "required": [],
+ "title": "Check Point Quantum module Configuration",
+ "type": "object"
</code_context>
<issue_to_address>
**question (bug_risk):** Validate that an entirely empty configuration schema is intentional for Quantum.
The manifest currently defines no configuration fields (`properties` is empty and `required` is `[]`). If Quantum needs any module-specific settings (e.g., credentials, URLs, tenant IDs), they won’t be configurable via the standard flow. Please confirm that no module-specific configuration is needed; if it is, define the relevant properties and mark any mandatory ones as `required`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
Split the existing Check Point automation module into distinct Harmony and Quantum modules, and introduce the initial Harmony Mobile connector implementation and packaging.
Changes:
- Renamed the existing module to Check Point Harmony (updated manifest metadata/version/categories).
- Added a new Check Point Quantum module skeleton (manifest/logo/changelog).
- Added the Harmony Mobile connector implementation, module entrypoint/Docker packaging, and an initial pytest suite.
Reviewed changes
Copilot reviewed 4 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CheckPointQuantum/manifest.json | Adds metadata for the new Check Point Quantum module. |
| CheckPointQuantum/logo.png | Adds the Quantum module logo asset. |
| CheckPointQuantum/CHANGELOG.md | Adds initial changelog entry for the Quantum module. |
| CheckPointHarmony/trigger_checkpoint_harmony_mobile_events.json | Adds trigger manifest for Harmony Mobile event collection. |
| CheckPointHarmony/tests/test_token_refresher.py | Adds unit tests for token refresher behavior and caching/expiration. |
| CheckPointHarmony/tests/test_http_client.py | Adds unit tests for Harmony Mobile HTTP client behavior (pagination, parsing). |
| CheckPointHarmony/tests/test_checkpoint_harmony_mobile_connector.py | Adds unit tests for the Harmony Mobile connector fetch/forward workflow. |
| CheckPointHarmony/tests/conftest.py | Adds pytest fixtures used across Harmony tests. |
| CheckPointHarmony/tests/init.py | Initializes Harmony tests package. |
| CheckPointHarmony/pyproject.toml | Adds Poetry config/dependencies and pytest/coverage settings for Harmony module. |
| CheckPointHarmony/manifest.json | Renames module to Check Point Harmony and updates slug/version/categories. |
| CheckPointHarmony/main.py | Adds Harmony module entrypoint registering the Harmony Mobile connector. |
| CheckPointHarmony/logo.png | Adds/updates Harmony module logo asset. |
| CheckPointHarmony/connectors/timestepper.py | Adds time window stepping helper for batched event collection. |
| CheckPointHarmony/connectors/metrics.py | Adds Prometheus metrics used by the connector. |
| CheckPointHarmony/connectors/client/token_refresher.py | Adds token refresher implementation for Check Point auth tokens. |
| CheckPointHarmony/connectors/client/http_client.py | Adds async HTTP client for fetching Harmony Mobile alerts. |
| CheckPointHarmony/connectors/client/init.py | Initializes client subpackage. |
| CheckPointHarmony/connectors/checkpoint_harmony_mobile.py | Adds Harmony Mobile connector implementation. |
| CheckPointHarmony/connectors/init.py | Adds module configuration model and module class for Harmony package. |
| CheckPointHarmony/connector_checkpoint_harmony_mobile_events.json | Adds connector manifest for Harmony Mobile event collection. |
| CheckPointHarmony/Dockerfile | Adds container build definition for the Harmony module. |
| CheckPointHarmony/CHANGELOG.md | Adds changelog entry for the Harmony rename/version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Split the existing Check Point automation into distinct Harmony and Quantum modules and update metadata accordingly.
New Features:
Enhancements: